Converting GlobalFilter to Jotai #2955
Conversation
| @@ -1,25 +0,0 @@ | |||
| import * as actionTemplates from './actions'; | |||
| import chromeReducer, { chromeInitialState } from '.'; | |||
There was a problem hiding this comment.
Do we need any of this middleware logic?
There was a problem hiding this comment.
There is the on event which leverages the middlewards. It can be and should done via jotai. https://github.com/Hyperkid123/insights-chrome/blob/master/src/chrome/create-chrome.ts#L100.
It was already done for the APP_NAVIGATION public event. You can follow similar approach.
| @@ -37,15 +32,3 @@ const globalFilter = { | |||
| [GLOBAL_FILTER_REMOVE]: onGlobalFilterRemove, | |||
| [GLOBAL_FILTER_UPDATE]: onTagSelect, | |||
| }; | |||
|
|
|||
| export const chromeInitialState: ReduxState = { | |||
There was a problem hiding this comment.
In create-chrome and other files, there are references to these states. I tried stubbing the state out as unknown and a few variations to make this pr smaller. Any recommendations?
There was a problem hiding this comment.
Move the types to the jotai atoms and reference it there. Most of the existing jotai atoms are just migrated redux state variables. You can check how its done there.
| }), | ||
| shallowEqual | ||
| ); | ||
| const { count, total, tags, sid, workloads, isLoaded } = useGlobalFilterState(); |
There was a problem hiding this comment.
Created a hook for this, may be unnecessary?
There was a problem hiding this comment.
When consolidating state variables, just be careful you are properly memorizing the state output. To prevent extra re-renders.
I don't see an issue with using the jotai atoms directly.
This will touch a lot of the code base, so I have some questions.